chrome/installer/util/delete_reg_value_work_item_unittest.cc - Issue 282363003: Add WOW64 support to the installer registry work items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/delete_reg_value_work_item_unittest.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src

Patch Set: add wow64 logic to installer_util. mini_installer tests. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/setup/install_worker.cc ('K') | « chrome/installer/util/delete_reg_value_work_item.cc ('k') | chrome/installer/util/google_update_settings_unittest.cc » ('j') | chrome/installer/util/install_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/delete_reg_value_work_item_unittest.cc

diff --git a/chrome/installer/util/delete_reg_value_work_item_unittest.cc b/chrome/installer/util/delete_reg_value_work_item_unittest.cc

index 5a884b11d46a79bac424bfed1faad321d2ae4968..04cfc6f027e945350773ab0152118f4389dd7709 100644

--- a/chrome/installer/util/delete_reg_value_work_item_unittest.cc

+++ b/chrome/installer/util/delete_reg_value_work_item_unittest.cc

@@ -62,14 +62,14 @@ TEST_F(DeleteRegValueWorkItemTest, DeleteExistingValue) {

REG_SZ, NULL, 0));

scoped_ptr<DeleteRegValueWorkItem> work_item1(

- WorkItem::CreateDeleteRegValueWorkItem(HKEY_CURRENT_USER, parent_key,

- name_str));

+ WorkItem::CreateDeleteRegValueWorkItem(

+ HKEY_CURRENT_USER, parent_key, name_str, WorkItem::kWow64Default));

scoped_ptr<DeleteRegValueWorkItem> work_item2(

- WorkItem::CreateDeleteRegValueWorkItem(HKEY_CURRENT_USER, parent_key,

- name_dword));

+ WorkItem::CreateDeleteRegValueWorkItem(

+ HKEY_CURRENT_USER, parent_key, name_dword, WorkItem::kWow64Default));

scoped_ptr<DeleteRegValueWorkItem> work_item3(

- WorkItem::CreateDeleteRegValueWorkItem(HKEY_CURRENT_USER, parent_key,

- name_empty));

+ WorkItem::CreateDeleteRegValueWorkItem(

+ HKEY_CURRENT_USER, parent_key, name_empty, WorkItem::kWow64Default));

EXPECT_TRUE(work_item1->Do());

EXPECT_TRUE(work_item2->Do());

@@ -113,11 +113,11 @@ TEST_F(DeleteRegValueWorkItemTest, DeleteNonExistentValue) {

EXPECT_FALSE(key.HasValue(name_dword.c_str()));

scoped_ptr<DeleteRegValueWorkItem> work_item1(

- WorkItem::CreateDeleteRegValueWorkItem(HKEY_CURRENT_USER, parent_key,

- name_str));

+ WorkItem::CreateDeleteRegValueWorkItem(

+ HKEY_CURRENT_USER, parent_key, name_str, WorkItem::kWow64Default));

scoped_ptr<DeleteRegValueWorkItem> work_item2(

- WorkItem::CreateDeleteRegValueWorkItem(HKEY_CURRENT_USER, parent_key,

- name_dword));

+ WorkItem::CreateDeleteRegValueWorkItem(

+ HKEY_CURRENT_USER, parent_key, name_dword, WorkItem::kWow64Default));

EXPECT_TRUE(work_item1->Do());

EXPECT_TRUE(work_item2->Do());