Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: chrome/installer/util/google_update_settings_unittest.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: nits. fix call to DeleteRegistryKey Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/delete_reg_value_work_item_unittest.cc ('k') | chrome/installer/util/install_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_update_settings_unittest.cc
diff --git a/chrome/installer/util/google_update_settings_unittest.cc b/chrome/installer/util/google_update_settings_unittest.cc
index 9eef4e51bd52447601598e002eeec61a6dffd77a..71c026267683e58163202f5e0f6b7cd0021db4a8 100644
--- a/chrome/installer/util/google_update_settings_unittest.cc
+++ b/chrome/installer/util/google_update_settings_unittest.cc
@@ -163,9 +163,14 @@ class GoogleUpdateSettingsTest : public testing::Test {
bool CreateApKey(WorkItemList* work_item_list, const std::wstring& value) {
HKEY reg_root = HKEY_CURRENT_USER;
std::wstring reg_key = GetApKeyPath();
- work_item_list->AddCreateRegKeyWorkItem(reg_root, reg_key);
- work_item_list->AddSetRegValueWorkItem(reg_root, reg_key,
- google_update::kRegApField, value.c_str(), true);
+ work_item_list->AddCreateRegKeyWorkItem(
+ reg_root, reg_key, WorkItem::kWow64Default);
+ work_item_list->AddSetRegValueWorkItem(reg_root,
+ reg_key,
+ WorkItem::kWow64Default,
+ google_update::kRegApField,
+ value.c_str(),
+ true);
if (!work_item_list->Do()) {
work_item_list->Rollback();
return false;
@@ -467,7 +472,8 @@ TEST_F(GoogleUpdateSettingsTest, UpdateInstallStatusTest) {
RegKey key;
if (key.Open(HKEY_CURRENT_USER, reg_key.c_str(), KEY_ALL_ACCESS) !=
ERROR_SUCCESS) {
- work_item_list->AddCreateRegKeyWorkItem(reg_root, reg_key);
+ work_item_list->AddCreateRegKeyWorkItem(
+ reg_root, reg_key, WorkItem::kWow64Default);
ASSERT_TRUE(work_item_list->Do()) << "Failed to create ClientState key.";
} else if (key.DeleteValue(google_update::kRegApField) == ERROR_SUCCESS) {
ap_key_deleted = true;
« no previous file with comments | « chrome/installer/util/delete_reg_value_work_item_unittest.cc ('k') | chrome/installer/util/install_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698