Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9761)

Unified Diff: chrome/installer/util/app_command.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: nits. fix call to DeleteRegistryKey Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/copy_reg_key_work_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/app_command.cc
diff --git a/chrome/installer/util/app_command.cc b/chrome/installer/util/app_command.cc
index 8f54e728741d821c63ebdab5583bc15c88f55ae6..78d931de5f110bfc7a1f507e14d512ee8d568865 100644
--- a/chrome/installer/util/app_command.cc
+++ b/chrome/installer/util/app_command.cc
@@ -70,11 +70,15 @@ bool AppCommand::Initialize(const base::win::RegKey& key) {
void AppCommand::AddWorkItems(HKEY predefined_root,
const base::string16& command_path,
WorkItemList* item_list) const {
- item_list->AddCreateRegKeyWorkItem(predefined_root, command_path)
+ item_list->AddCreateRegKeyWorkItem(
+ predefined_root, command_path, WorkItem::kWow64Default)
->set_log_message("creating AppCommand registry key");
- item_list->AddSetRegValueWorkItem(predefined_root, command_path,
+ item_list->AddSetRegValueWorkItem(predefined_root,
+ command_path,
+ WorkItem::kWow64Default,
google_update::kRegCommandLineField,
- command_line_, true)
+ command_line_,
+ true)
->set_log_message("setting AppCommand CommandLine registry value");
for (int i = 0; i < arraysize(kNameBoolVars); ++i) {
@@ -86,13 +90,13 @@ void AppCommand::AddWorkItems(HKEY predefined_root,
if (var_data) {
item_list->AddSetRegValueWorkItem(predefined_root,
command_path,
+ WorkItem::kWow64Default,
var_name,
static_cast<DWORD>(1),
true);
} else {
- item_list->AddDeleteRegValueWorkItem(predefined_root,
- command_path,
- var_name);
+ item_list->AddDeleteRegValueWorkItem(
+ predefined_root, command_path, WorkItem::kWow64Default, var_name);
}
}
}
« no previous file with comments | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/copy_reg_key_work_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698