chrome/installer/util/create_reg_key_work_item_unittest.cc - Issue 282363003: Add WOW64 support to the installer registry work items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/create_reg_key_work_item_unittest.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src

Patch Set: nit: style on braces Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/util/create_reg_key_work_item.cc ('K') | « chrome/installer/util/create_reg_key_work_item.cc ('k') | chrome/installer/util/delete_reg_key_work_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/create_reg_key_work_item_unittest.cc

diff --git a/chrome/installer/util/create_reg_key_work_item_unittest.cc b/chrome/installer/util/create_reg_key_work_item_unittest.cc

index acc3e185a82fd344275d069a6cd670e2708055ca..6b4bc15f01e132d3ad7109c11153e456bf4a0f4a 100644

--- a/chrome/installer/util/create_reg_key_work_item_unittest.cc

+++ b/chrome/installer/util/create_reg_key_work_item_unittest.cc

@@ -54,8 +54,8 @@ TEST_F(CreateRegKeyWorkItemTest, CreateKey) {

key_to_create = key_to_create.AppendASCII("d");

scoped_ptr<CreateRegKeyWorkItem> work_item(

- WorkItem::CreateCreateRegKeyWorkItem(HKEY_CURRENT_USER,

- key_to_create.value()));

+ WorkItem::CreateCreateRegKeyWorkItem(

+ HKEY_CURRENT_USER, key_to_create.value(), WorkItem::kWow64Default));

EXPECT_TRUE(work_item->Do());

@@ -80,8 +80,8 @@ TEST_F(CreateRegKeyWorkItemTest, CreateExistingKey) {

key.Create(HKEY_CURRENT_USER, key_to_create.value().c_str(), KEY_READ));

scoped_ptr<CreateRegKeyWorkItem> work_item(

- WorkItem::CreateCreateRegKeyWorkItem(HKEY_CURRENT_USER,

- key_to_create.value()));

+ WorkItem::CreateCreateRegKeyWorkItem(

+ HKEY_CURRENT_USER, key_to_create.value(), WorkItem::kWow64Default));

EXPECT_TRUE(work_item->Do());

@@ -108,8 +108,8 @@ TEST_F(CreateRegKeyWorkItemTest, CreateSharedKey) {

key_to_create_3 = key_to_create_3.AppendASCII("ccc");

scoped_ptr<CreateRegKeyWorkItem> work_item(

- WorkItem::CreateCreateRegKeyWorkItem(HKEY_CURRENT_USER,

- key_to_create_3.value()));

+ WorkItem::CreateCreateRegKeyWorkItem(

+ HKEY_CURRENT_USER, key_to_create_3.value(), WorkItem::kWow64Default));

EXPECT_TRUE(work_item->Do());

@@ -147,8 +147,8 @@ TEST_F(CreateRegKeyWorkItemTest, RollbackWithMissingKey) {

key_to_create_3 = key_to_create_3.AppendASCII("cccc");

scoped_ptr<CreateRegKeyWorkItem> work_item(

- WorkItem::CreateCreateRegKeyWorkItem(HKEY_CURRENT_USER,

- key_to_create_3.value()));

+ WorkItem::CreateCreateRegKeyWorkItem(

+ HKEY_CURRENT_USER, key_to_create_3.value(), WorkItem::kWow64Default));

EXPECT_TRUE(work_item->Do());

@@ -177,8 +177,8 @@ TEST_F(CreateRegKeyWorkItemTest, RollbackWithSetValue) {

key_to_create = key_to_create.AppendASCII("aaaaa");

scoped_ptr<CreateRegKeyWorkItem> work_item(

- WorkItem::CreateCreateRegKeyWorkItem(HKEY_CURRENT_USER,

- key_to_create.value()));

+ WorkItem::CreateCreateRegKeyWorkItem(

+ HKEY_CURRENT_USER, key_to_create.value(), WorkItem::kWow64Default));

EXPECT_TRUE(work_item->Do());