chrome/test/mini_installer_test/test.cc - Issue 282363003: Add WOW64 support to the installer registry work items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/mini_installer_test/test.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src

Patch Set: code review changes. found a few APIs that needed the WOW64 flag. Fix ordering of some parameters. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/mini_installer_test/test.cc

diff --git a/chrome/test/mini_installer_test/test.cc b/chrome/test/mini_installer_test/test.cc

index 43b5428e4807a9345bb785d65554250d7ea31d6e..a479cb61768a481d131d673ba59bb522cb5ecea6 100644

--- a/chrome/test/mini_installer_test/test.cc

+++ b/chrome/test/mini_installer_test/test.cc

@@ -241,7 +241,7 @@ TEST_F(MiniInstallTest, RepairRegistryOnFullUser) {

content::RESULT_CODE_HUNG, NULL);

ASSERT_TRUE(installer_test::DeleteRegistryKey(

false, // system level

- InstallationValidator::CHROME_SINGLE));

+ InstallationValidator::CHROME_SINGLE, 0)); // no WOW64

ASSERT_TRUE(

installer_test::Install(full_installer_, SwitchBuilder().AddChrome()));

ASSERT_TRUE(installer_test::ValidateInstall(false,

@@ -255,7 +255,7 @@ TEST_F(MiniInstallTest, RepairRegistryOnFullSys) {

InstallationValidator::CHROME_SINGLE, provider_->GetCurrentBuild()));

ASSERT_TRUE(installer_test::DeleteRegistryKey(

true, // system level

- InstallationValidator::CHROME_SINGLE));

+ InstallationValidator::CHROME_SINGLE, 0)); // no WOW64

ASSERT_TRUE(installer_test::Install(full_installer_,

SwitchBuilder().AddChrome().AddSystemInstall()));

ASSERT_TRUE(installer_test::ValidateInstall(true,