Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3964)

Unified Diff: chrome/installer/util/install_util.h

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: code review changes. found a few APIs that needed the WOW64 flag. Fix ordering of some parameters. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/install_util.h
diff --git a/chrome/installer/util/install_util.h b/chrome/installer/util/install_util.h
index 1c3d0cba605b66d8c30993d4ad976ad3dc9797b1..383e5820bd676eca89361e87dcb95637c2a4a59b 100644
--- a/chrome/installer/util/install_util.h
+++ b/chrome/installer/util/install_util.h
@@ -113,11 +113,14 @@ class InstallUtil {
static bool GetEULASentinelFilePath(base::FilePath* path);
// Deletes the registry key at path key_path under the key given by root_key.
- static bool DeleteRegistryKey(HKEY root_key, const base::string16& key_path);
+ static bool DeleteRegistryKey(HKEY root_key,
+ const base::string16& key_path,
+ REGSAM wow64_access);
// Deletes the registry value named value_name at path key_path under the key
// given by reg_root.
static bool DeleteRegistryValue(HKEY reg_root, const base::string16& key_path,
+ REGSAM wow64_access,
grt (UTC plus 2) 2014/05/22 22:17:23 nice catch!
const base::string16& value_name);
// An interface to a predicate function for use by DeleteRegistryKeyIf and
@@ -143,6 +146,7 @@ class InstallUtil {
HKEY root_key,
const base::string16& key_to_delete_path,
const base::string16& key_to_test_path,
+ REGSAM wow64_access,
const wchar_t* value_name,
const RegistryValuePredicate& predicate);
@@ -152,6 +156,7 @@ class InstallUtil {
static ConditionalDeleteResult DeleteRegistryValueIf(
HKEY root_key,
const wchar_t* key_path,
+ REGSAM wow64_access,
const wchar_t* value_name,
const RegistryValuePredicate& predicate);

Powered by Google App Engine
This is Rietveld 408576698