Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: code review changes. found a few APIs that needed the WOW64 flag. Fix ordering of some parameters. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install_worker_unittest.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | chrome/installer/util/delete_reg_key_work_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/setup_main.cc
diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc
index 57fe5e5c25a0f55cbb91dc54b2c4836a8f7dc49f..9440759264528e37839076ca3270b96e71057e6e 100644
--- a/chrome/installer/setup/setup_main.cc
+++ b/chrome/installer/setup/setup_main.cc
@@ -264,11 +264,14 @@ installer::InstallStatus RenameChromeExecutables(
++it) {
version_key = (*it)->distribution()->GetVersionKey();
install_list->AddDeleteRegValueWorkItem(
- reg_root, version_key, google_update::kRegOldVersionField);
+ reg_root, version_key, WorkItem::kWow64Default,
+ google_update::kRegOldVersionField);
install_list->AddDeleteRegValueWorkItem(
- reg_root, version_key, google_update::kRegCriticalVersionField);
+ reg_root, version_key, WorkItem::kWow64Default,
+ google_update::kRegCriticalVersionField);
install_list->AddDeleteRegValueWorkItem(
- reg_root, version_key, google_update::kRegRenameCmdField);
+ reg_root, version_key, WorkItem::kWow64Default,
+ google_update::kRegRenameCmdField);
}
installer::InstallStatus ret = installer::RENAME_SUCCESSFUL;
if (!install_list->Do()) {
« no previous file with comments | « chrome/installer/setup/install_worker_unittest.cc ('k') | chrome/installer/setup/uninstall.cc » ('j') | chrome/installer/util/delete_reg_key_work_item.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698