chrome/installer/setup/install.cc - Issue 282363003: Add WOW64 support to the installer registry work items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src

Patch Set: code review changes. found a few APIs that needed the WOW64 flag. Fix ordering of some parameters. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/setup/install.cc

diff --git a/chrome/installer/setup/install.cc b/chrome/installer/setup/install.cc

index e7cc375f145a408220736757167b814bc362f861..cb675ac6e5e5d14db87b4038121e42bec24850c4 100644

--- a/chrome/installer/setup/install.cc

+++ b/chrome/installer/setup/install.cc

@@ -136,7 +136,7 @@ void AddChromeToMediaPlayerList() {

reg_path.append(installer::kChromeExe);

VLOG(1) << "Adding Chrome to Media player list at " << reg_path;

scoped_ptr<WorkItem> work_item(WorkItem::CreateCreateRegKeyWorkItem(

- HKEY_LOCAL_MACHINE, reg_path));

+ HKEY_LOCAL_MACHINE, reg_path, WorkItem::kWow64Default));

// if the operation fails we log the error but still continue

if (!work_item.get()->Do())