Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4703)

Unified Diff: chrome/installer/util/app_command.cc

Issue 282363003: Add WOW64 support to the installer registry work items (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/app_command.cc
diff --git a/chrome/installer/util/app_command.cc b/chrome/installer/util/app_command.cc
index 8f54e728741d821c63ebdab5583bc15c88f55ae6..2ae56a6aec663f1736ebe3ad80ae13ba80db4342 100644
--- a/chrome/installer/util/app_command.cc
+++ b/chrome/installer/util/app_command.cc
@@ -70,12 +70,15 @@ bool AppCommand::Initialize(const base::win::RegKey& key) {
void AppCommand::AddWorkItems(HKEY predefined_root,
const base::string16& command_path,
WorkItemList* item_list) const {
- item_list->AddCreateRegKeyWorkItem(predefined_root, command_path)
- ->set_log_message("creating AppCommand registry key");
- item_list->AddSetRegValueWorkItem(predefined_root, command_path,
- google_update::kRegCommandLineField,
- command_line_, true)
- ->set_log_message("setting AppCommand CommandLine registry value");
+ item_list->AddCreateRegKeyWorkItem(predefined_root,
+ command_path,
+ WorkItem::WOW64_DEFAULT)
+ ->set_log_message("creating AppCommand registry key");
+ item_list->AddSetRegValueWorkItem(
+ predefined_root, command_path,
+ google_update::kRegCommandLineField,
+ command_line_, true, WorkItem::WOW64_DEFAULT)
+ ->set_log_message("setting AppCommand CommandLine registry value");
for (int i = 0; i < arraysize(kNameBoolVars); ++i) {
const wchar_t* var_name = kNameBoolVars[i].name;
@@ -88,11 +91,13 @@ void AppCommand::AddWorkItems(HKEY predefined_root,
command_path,
var_name,
static_cast<DWORD>(1),
- true);
+ true,
+ WorkItem::WOW64_DEFAULT);
} else {
item_list->AddDeleteRegValueWorkItem(predefined_root,
command_path,
- var_name);
+ var_name,
+ WorkItem::WOW64_DEFAULT);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698