Add WOW64 support to the installer registry work items

chrome/installer/util/work_item_list.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_INSTALLER_UTIL_WORK_ITEM_LIST_H_
 #define CHROME_INSTALLER_UTIL_WORK_ITEM_LIST_H_
 
 #include <windows.h>
 
 #include <list>
@@ skipping 29 matching lines @@
   virtual void AddWorkItem(WorkItem* work_item);
 
   // Add a CallbackWorkItem that invokes a callback.
   virtual WorkItem* AddCallbackWorkItem(
       base::Callback<bool(const CallbackWorkItem&)> callback);
 
   // Add a CopyRegKeyWorkItem that recursively copies a given registry key.
   virtual WorkItem* AddCopyRegKeyWorkItem(HKEY predefined_root,
                                           const std::wstring& source_key_path,
                                           const std::wstring& dest_key_path,
-                                          CopyOverWriteOption overwrite_option);
+                                          CopyOverWriteOption overwrite_option,
+                                          RegWow64ViewOption reg_wow64_option);

[grt (UTC plus 2), 2014/05/16 18:26:11]

it looks like it's going to be pretty intrusive to plumb this option through all
consumers. i think this is one of those cases where a default argument is
acceptable. does that simplify things?

 
   // Add a CopyTreeWorkItem to the list of work items.
   // See the NOTE in the documentation for the CopyTreeWorkItem class for
   // special considerations regarding |temp_dir|.
   virtual WorkItem* AddCopyTreeWorkItem(
       const std::wstring& source_path,
       const std::wstring& dest_path,
       const std::wstring& temp_dir,
       CopyOverWriteOption overwrite_option,
       const std::wstring& alternative_path = L"");
 
   // Add a CreateDirWorkItem that creates a directory at the given path.
   virtual WorkItem* AddCreateDirWorkItem(const base::FilePath& path);
 
   // Add a CreateRegKeyWorkItem that creates a registry key at the given
   // path.
-  virtual WorkItem* AddCreateRegKeyWorkItem(HKEY predefined_root,
-                                            const std::wstring& path);
+  virtual WorkItem* AddCreateRegKeyWorkItem(
+      HKEY predefined_root,
+      const std::wstring& path,
+      RegWow64ViewOption reg_wow64_option);
 
   // Add a DeleteRegKeyWorkItem that deletes a registry key from the given
   // path.
-  virtual WorkItem* AddDeleteRegKeyWorkItem(HKEY predefined_root,
-                                            const std::wstring& path);
+  virtual WorkItem* AddDeleteRegKeyWorkItem(
+      HKEY predefined_root,
+      const std::wstring& path,
+      RegWow64ViewOption reg_wow64_option);
 
   // Add a DeleteRegValueWorkItem that deletes registry value of type REG_SZ
   // or REG_DWORD.
-  virtual WorkItem* AddDeleteRegValueWorkItem(HKEY predefined_root,
-                                              const std::wstring& key_path,
-                                              const std::wstring& value_name);
+  virtual WorkItem* AddDeleteRegValueWorkItem(
+      HKEY predefined_root,
+      const std::wstring& key_path,
+      const std::wstring& value_name,
+      RegWow64ViewOption reg_wow64_option);
 
   // Add a DeleteTreeWorkItem that recursively deletes a file system
   // hierarchy at the given root path. A key file can be optionally specified
   // by key_path.
   virtual WorkItem* AddDeleteTreeWorkItem(
       const base::FilePath& root_path,
       const base::FilePath& temp_path,
       const std::vector<base::FilePath>& key_paths);
 
   // Same as above but without support for key files.
   virtual WorkItem* AddDeleteTreeWorkItem(const base::FilePath& root_path,
                                           const base::FilePath& temp_path);
 
   // Add a MoveTreeWorkItem to the list of work items.
   virtual WorkItem* AddMoveTreeWorkItem(const std::wstring& source_path,
                                         const std::wstring& dest_path,
                                         const std::wstring& temp_dir,
                                         MoveTreeOption duplicate_option);
 
   // Add a SetRegValueWorkItem that sets a registry value with REG_SZ type
   // at the key with specified path.
   virtual WorkItem* AddSetRegValueWorkItem(HKEY predefined_root,
                                            const std::wstring& key_path,
                                            const std::wstring& value_name,
                                            const std::wstring& value_data,
-                                           bool overwrite);
+                                           bool overwrite,
+                                           RegWow64ViewOption reg_wow64_option);
 
   // Add a SetRegValueWorkItem that sets a registry value with REG_DWORD type
   // at the key with specified path.
   virtual WorkItem* AddSetRegValueWorkItem(HKEY predefined_root,
                                            const std::wstring& key_path,
                                            const std::wstring& value_name,
                                            DWORD value_data,
-                                           bool overwrite);
+                                           bool overwrite,
+                                           RegWow64ViewOption reg_wow64_option);
 
   // Add a SetRegValueWorkItem that sets a registry value with REG_QWORD type
   // at the key with specified path.
   virtual WorkItem* AddSetRegValueWorkItem(HKEY predefined_root,
                                            const std::wstring& key_path,
                                            const std::wstring& value_name,
                                            int64 value_data,
-                                           bool overwrite);
+                                           bool overwrite,
+                                           RegWow64ViewOption reg_wow64_option);
 
   // Add a SelfRegWorkItem that registers or unregisters a DLL at the
   // specified path. If user_level_registration is true, then alternate
   // registration and unregistration entry point names will be used.
   virtual WorkItem* AddSelfRegWorkItem(const std::wstring& dll_path,
                                        bool do_register,
                                        bool user_level_registration);
 
  protected:
   friend class WorkItem;
@@ skipping 33 matching lines @@
   // Execute the WorkItems in the same order as they are added to the list.
   // If a WorkItem fails, the function will return failure but all other
   // WorkItems will still be executed.
   virtual bool Do();
 
   // No-op.
   virtual void Rollback();
 };
 
 #endif  // CHROME_INSTALLER_UTIL_WORK_ITEM_LIST_H_