Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ios/chrome/browser/tabs/tab_model_unittest.mm

Issue 2823623002: Remove usage of Tab's |url| property from TabModel. (Closed)
Patch Set: test + formatting fixes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/web/navigation/navigation_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_model_unittest.mm b/ios/chrome/browser/tabs/tab_model_unittest.mm
index 004cc4f7e099d7df94f3666a210e36467687f493..9857518413c0607426a363777c53437d508c4acf 100644
--- a/ios/chrome/browser/tabs/tab_model_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_model_unittest.mm
@@ -349,6 +349,8 @@ void SetTabModel(TabModel* tab_model) {
openedByDOM:NO
atIndex:0
inBackground:NO];
+ web::WebStateImpl* web_state = static_cast<web::WebStateImpl*>(tab.webState);
+ web_state->GetNavigationManagerImpl().CommitPendingItem();
SessionWindowIOS* window(CreateSessionWindow());
[tab_model_ restoreSessionWindow:window];
@@ -368,6 +370,8 @@ void SetTabModel(TabModel* tab_model) {
openedByDOM:NO
atIndex:0
inBackground:NO];
+ web::WebStateImpl* web_state = static_cast<web::WebStateImpl*>(tab0.webState);
+ web_state->GetNavigationManagerImpl().CommitPendingItem();
Tab* tab1 = [tab_model_ insertTabWithURL:GURL(kChromeUINewTabURL)
referrer:web::Referrer()
transition:ui::PAGE_TRANSITION_TYPED
@@ -375,6 +379,8 @@ void SetTabModel(TabModel* tab_model) {
openedByDOM:NO
atIndex:1
inBackground:NO];
+ web_state = static_cast<web::WebStateImpl*>(tab1.webState);
+ web_state->GetNavigationManagerImpl().CommitPendingItem();
SessionWindowIOS* window(CreateSessionWindow());
[tab_model_ restoreSessionWindow:window];
@@ -399,6 +405,8 @@ void SetTabModel(TabModel* tab_model) {
openedByDOM:NO
atIndex:0
inBackground:NO];
+ web::WebStateImpl* web_state = static_cast<web::WebStateImpl*>(tab.webState);
+ web_state->GetNavigationManagerImpl().CommitPendingItem();
SessionWindowIOS* window(CreateSessionWindow());
[tab_model_ restoreSessionWindow:window];
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/web/navigation/navigation_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698