Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Side by Side Diff: ios/web/navigation/navigation_manager_impl.h

Issue 2823623002: Remove usage of Tab's |url| property from TabModel. (Closed)
Patch Set: test + formatting fixes Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
6 #define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 6 #define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // type and user agent override option, making it the pending item. If pending 98 // type and user agent override option, making it the pending item. If pending
99 // item is the same as the current item, this does nothing. |referrer| may be 99 // item is the same as the current item, this does nothing. |referrer| may be
100 // nil if there isn't one. The item starts out as pending, and will be lost 100 // nil if there isn't one. The item starts out as pending, and will be lost
101 // unless |-commitPendingItem| is called. 101 // unless |-commitPendingItem| is called.
102 void AddPendingItem(const GURL& url, 102 void AddPendingItem(const GURL& url,
103 const web::Referrer& referrer, 103 const web::Referrer& referrer,
104 ui::PageTransition navigation_type, 104 ui::PageTransition navigation_type,
105 NavigationInitiationType initiation_type, 105 NavigationInitiationType initiation_type,
106 UserAgentOverrideOption user_agent_override_option); 106 UserAgentOverrideOption user_agent_override_option);
107 107
108 // Commits the pending item, if any.
109 void CommitPendingItem();
110
108 // NavigationManager: 111 // NavigationManager:
109 BrowserState* GetBrowserState() const override; 112 BrowserState* GetBrowserState() const override;
110 WebState* GetWebState() const override; 113 WebState* GetWebState() const override;
111 NavigationItem* GetVisibleItem() const override; 114 NavigationItem* GetVisibleItem() const override;
112 NavigationItem* GetLastCommittedItem() const override; 115 NavigationItem* GetLastCommittedItem() const override;
113 NavigationItem* GetPendingItem() const override; 116 NavigationItem* GetPendingItem() const override;
114 NavigationItem* GetTransientItem() const override; 117 NavigationItem* GetTransientItem() const override;
115 void DiscardNonCommittedItems() override; 118 void DiscardNonCommittedItems() override;
116 void LoadURLWithParams(const NavigationManager::WebLoadParams&) override; 119 void LoadURLWithParams(const NavigationManager::WebLoadParams&) override;
117 void AddTransientURLRewriter( 120 void AddTransientURLRewriter(
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 // List of transient url rewriters added by |AddTransientURLRewriter()|. 179 // List of transient url rewriters added by |AddTransientURLRewriter()|.
177 std::unique_ptr<std::vector<BrowserURLRewriter::URLRewriter>> 180 std::unique_ptr<std::vector<BrowserURLRewriter::URLRewriter>>
178 transient_url_rewriters_; 181 transient_url_rewriters_;
179 182
180 DISALLOW_COPY_AND_ASSIGN(NavigationManagerImpl); 183 DISALLOW_COPY_AND_ASSIGN(NavigationManagerImpl);
181 }; 184 };
182 185
183 } // namespace web 186 } // namespace web
184 187
185 #endif // IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 188 #endif // IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
OLDNEW
« no previous file with comments | « ios/chrome/browser/tabs/tab_model_unittest.mm ('k') | ios/web/navigation/navigation_manager_impl.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698