Remove usage of Tab's |url| property from TabModel.

ios/chrome/browser/tabs/tab_model.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/tabs/tab_model.h"
 
 #include <cstdint>
 #include <utility>
 #include <vector>
 
@@ skipping 592 matching lines @@
   if (_tabUsageRecorder)
     _tabUsageRecorder->RecordPrimaryTabModelChange(primary, self.currentTab);
 }
 
 - (NSSet*)currentlyReferencedExternalFiles {
   NSMutableSet* referencedFiles = [NSMutableSet set];
   if (!_browserState)
     return referencedFiles;
   // Check the currently open tabs for external files.
   for (Tab* tab in self) {
-    if (UrlIsExternalFileReference(tab.url)) {
-      NSString* fileName = base::SysUTF8ToNSString(tab.url.ExtractFileName());
+    const GURL& URL = tab.lastCommittedURL;
+    if (UrlIsExternalFileReference(URL)) {
+      NSString* fileName = base::SysUTF8ToNSString(URL.ExtractFileName());

[kkhorimoto, 2017/04/14 20:37:40]

A file is currently reference if it's in the content area, which would be the
last committed.

[Eugene But (OOO till 7-30), 2017/04/14 21:46:10]

Should we include both lastCommitted and pending?

[kkhorimoto, 2017/05/31 22:30:04]

Done.

       [referencedFiles addObject:fileName];
     }
   }
   // Do the same for the recently closed tabs.
   sessions::TabRestoreService* restoreService =
       IOSChromeTabRestoreServiceFactory::GetForBrowserState(_browserState);
   DCHECK(restoreService);
   for (const auto& entry : restoreService->entries()) {
     sessions::TabRestoreService::Tab* tab =
         static_cast<sessions::TabRestoreService::Tab*>(entry.get());
@@ skipping 140 matching lines @@
 
     if (persistState && self.currentTab)
       [self.currentTab recordStateInHistory];
     _webStateList->ActivateWebStateAt(static_cast<int>(selectedIndex));
   }
 
   // If there was only one tab and it was the new tab page, clobber it.
   BOOL closedNTPTab = NO;
   if (oldCount == 1) {
     Tab* tab = [self tabAtIndex:0];
-    if (tab.url == GURL(kChromeUINewTabURL)) {
+    if (tab.lastCommittedURL == GURL(kChromeUINewTabURL)) {

[kkhorimoto, 2017/04/14 20:37:40]

Loads aren't occurring during session restoration, so last committed is
sufficient.

[sdefresne, 2017/04/18 15:54:34]

This is also called when restoring a session after a crash. There can be a
pending tab if the user started a navigation and then immediately tapped the
"Restore tabs" button from the infobar. I think we also need to check pending
here as we do not want to close the pending tab in that case.

[kkhorimoto, 2017/05/31 22:30:04]

Done.

       [self closeTab:tab];
       closedNTPTab = YES;
       oldCount = 0;
     }
   }
   if (_tabUsageRecorder)
     _tabUsageRecorder->InitialRestoredTabs(self.currentTab, restoredTabs.get());
   return closedNTPTab;
 }
 
@@ skipping 35 matching lines @@
 }
 
 // Called when UIApplicationWillEnterForegroundNotification is received.
 - (void)applicationWillEnterForeground:(NSNotification*)notify {
   if (_tabUsageRecorder) {
     _tabUsageRecorder->AppWillEnterForeground();
   }
 }
 
 @end