Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2823613002: PlzNavigate: add dump to understand pdf navigation cancellation (Closed)
Patch Set: Addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index 4036937d35a7121727d7308a8b702d132d10d4f5..cf60f550d1451afc6db8f2c534b2fd3888f52a24 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -6,6 +6,7 @@
#include <utility>
+#include "base/debug/dump_without_crashing.h"
#include "base/memory/ptr_util.h"
#include "content/browser/appcache/appcache_navigation_handle.h"
#include "content/browser/appcache/chrome_appcache_service.h"
@@ -610,6 +611,12 @@ void NavigationRequest::OnRequestFailed(bool has_stale_copy_in_cache,
// If the request was canceled by the user do not show an error page.
if (net_error == net::ERR_ABORTED) {
+ // TODO(clamy): Remove this once we understand the root cause of
+ // crbug.com/709771.
+ std::string path = common_params_.url.path();
+ if (path.length() >= 4 && path.substr(path.length() - 4) == ".pdf")
+ base::debug::DumpWithoutCrashing();
+
frame_tree_node_->ResetNavigationRequest(false, true);
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698