Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2823593002: Prevent crash in NativeWidgetAura::IsMouseEventsEnabled() when no root window (Closed)

Created:
3 years, 8 months ago by yoshiki
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent crash in NativeWidgetAura::IsMouseEventsEnabled() when no root window This patch adds a root window check in NativeWidgetAura::IsMouseEventsEnabled(). BUG=712091 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
yoshiki
Sadrul, PTAL. Thanks.
3 years, 8 months ago (2017-04-17 04:29:30 UTC) #8
yoshiki
Scott, could you take a look?
3 years, 8 months ago (2017-04-18 06:20:30 UTC) #10
sky
On 2017/04/18 06:20:30, yoshiki wrote: > Scott, could you take a look? I think this ...
3 years, 8 months ago (2017-04-18 16:14:25 UTC) #11
yoshiki
3 years, 8 months ago (2017-04-19 15:32:44 UTC) #12
On 2017/04/18 16:14:25, sky wrote:
> On 2017/04/18 06:20:30, yoshiki wrote:
> > Scott, could you take a look?
> 
> I think this will fix the crash, but I'm worried there is something more wrong
> here. In order for this crash to occur the widget would not be parented, which
> is likely to cause other problems. Why is ArcCustomNotificationView trying to
> Show() a Widget that isn't attached to a root window?

Ok thanks, let me investigate the root cause.

Powered by Google App Engine
This is Rietveld 408576698