Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2823543002: dart2js: eliminate useless conditionals (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: eliminate useless conditionals 1. Simplify HPhi nodes that merge refinements of the same value. 2. Replace the condition of HIf with a constant when the HIf does nothing (no controlled statements or phis). Together with existing optimizations, this can optimize `s?.toString()` to `s` when `s` is known to be a nullable String. BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/b0599b264736a3dff5b9ea26de47deac427b5447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -3 lines) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 3 chunks +84 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (10 generated)
sra1
3 years, 8 months ago (2017-04-14 19:13:29 UTC) #10
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-14 20:11:45 UTC) #11
sra1
3 years, 8 months ago (2017-04-14 21:34:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:120001) manually as
b0599b264736a3dff5b9ea26de47deac427b5447 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698