Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 282353002: Add GN build file for surface. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
brettw, piman
CC:
chromium-reviews, brettw
Visibility:
Public.

Description

Add GN build file for surface. This is needed by content. BUG=None TEST=gn gen out/Debug; followed by ninja -C out/Debug surface R=brettw@chromium.org,piman@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271163

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Patch Set 3 : explain why #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A ui/surface/BUILD.gn View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
6 years, 7 months ago (2014-05-16 16:00:48 UTC) #1
brettw
lgtm https://codereview.chromium.org/282353002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/282353002/diff/1/BUILD.gn#newcode87 BUILD.gn:87: "//ui/surface", Is this because it depends on Skia? ...
6 years, 7 months ago (2014-05-16 16:57:04 UTC) #2
piman
LGTM if Brett is happy.
6 years, 7 months ago (2014-05-16 19:32:36 UTC) #3
tfarina
https://codereview.chromium.org/282353002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/282353002/diff/1/BUILD.gn#newcode87 BUILD.gn:87: "//ui/surface", On 2014/05/16 16:57:04, brettw wrote: > Is this ...
6 years, 7 months ago (2014-05-16 21:24:24 UTC) #4
tfarina
https://codereview.chromium.org/282353002/diff/1/ui/surface/BUILD.gn File ui/surface/BUILD.gn (right): https://codereview.chromium.org/282353002/diff/1/ui/surface/BUILD.gn#newcode30 ui/surface/BUILD.gn:30: #'include_dirs': [ On 2014/05/16 16:57:04, brettw wrote: > Just ...
6 years, 7 months ago (2014-05-16 21:24:34 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-17 03:29:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/282353002/40001
6 years, 7 months ago (2014-05-17 03:31:21 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 04:55:19 UTC) #8
Message was sent while issue was closed.
Change committed as 271163

Powered by Google App Engine
This is Rietveld 408576698