Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
index 12429692faa194a6ff1c690068c10601a097ae39..78b8b3f962e21a2aada2511822fc5ec75daed960 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
@@ -19,6 +19,7 @@ class Timer;
namespace page_load_metrics {
class PageTimingMetricsSender;
+class PageTimingSender;
// MetricsRenderFrameObserver observes RenderFrame notifications, and sends page
// load timing information to the browser process over IPC. A
@@ -43,15 +44,16 @@ class MetricsRenderFrameObserver : public content::RenderFrameObserver {
void FrameDetached() override;
private:
- // Will be null when we're not actively sending metrics.
- std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
-
void SendMetrics();
virtual bool ShouldSendMetrics() const;
virtual mojom::PageLoadTimingPtr GetTiming() const;
virtual std::unique_ptr<base::Timer> CreateTimer() const;
+ virtual std::unique_ptr<PageTimingSender> CreatePageTimingSender();
virtual bool HasNoRenderFrame() const;
+ // Will be null when we're not actively sending metrics.
+ std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
+
DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);
};

Powered by Google App Engine
This is Rietveld 408576698