Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/renderer/page_load_metrics/page_timing_sender.h

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Addressed comments, remove unnecessary RunUntilIdle, call OnTimingUpdated directly in unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/page_timing_sender.h
diff --git a/chrome/renderer/page_load_metrics/page_timing_sender.h b/chrome/renderer/page_load_metrics/page_timing_sender.h
new file mode 100644
index 0000000000000000000000000000000000000000..4415d140d4ab3faaf4f90f41b71ebfae86898c2f
--- /dev/null
+++ b/chrome/renderer/page_load_metrics/page_timing_sender.h
@@ -0,0 +1,23 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_SENDER_H_
+#define CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_SENDER_H_
+
+#include "chrome/common/page_load_metrics/page_load_timing.h"
+
+namespace page_load_metrics {
+
+// PageTimingSender is an interface that is responsible for sending page load
+// timing. SendTiming() should be implemented to send page load timing over
+// mojo IPC.
+class PageTimingSender {
Bryan McQuade 2017/04/26 16:04:34 i like this abstraction, but let's do this slightl
lpy 2017/04/27 10:58:35 I assume the owner of PageTimingSender should be M
Bryan McQuade 2017/04/27 15:42:32 I'll have to look at the code more to understand w
+ public:
+ virtual void SendTiming(const PageLoadTiming& timing,
+ const PageLoadMetadata& metadata) = 0;
+};
+
+} // namespace page_load_metrics
+
+#endif // CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_SENDER_H_

Powered by Google App Engine
This is Rietveld 408576698