Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.h

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Addressed comments, remove unnecessary RunUntilIdle, call OnTimingUpdated directly in unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
diff --git a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
index fc3fba1f51412bc22ab5a8d28e099db496ea333b..c0f36b83881c7ecdeff6352aac4ef6f2e4c40595 100644
--- a/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
+++ b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
@@ -21,6 +21,8 @@ class Sender;
namespace page_load_metrics {
+class PageTimingSender;
+
// PageTimingMetricsSender is responsible for sending page load timing metrics
// over IPC. PageTimingMetricsSender may coalesce sent IPCs in order to
// minimize IPC contention.
@@ -28,6 +30,7 @@ class PageTimingMetricsSender {
public:
PageTimingMetricsSender(IPC::Sender* ipc_sender,
int routing_id,
+ PageTimingSender* page_timing_sender,
std::unique_ptr<base::Timer> timer,
const PageLoadTiming& initial_timing);
~PageTimingMetricsSender();
@@ -44,6 +47,7 @@ class PageTimingMetricsSender {
IPC::Sender* const ipc_sender_;
const int routing_id_;
+ PageTimingSender* const page_timing_sender_;
std::unique_ptr<base::Timer> timer_;
PageLoadTiming last_timing_;

Powered by Google App Engine
This is Rietveld 408576698