Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Addressed comments, remove unnecessary RunUntilIdle, call OnTimingUpdated directly in unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
index 2466dd157bc42d9a0fc3d61dca65c40a336254da..50f1c24e41a5d255b0a34bc5490791e3b30a63ab 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
@@ -10,6 +10,7 @@
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/process/kill.h"
+#include "base/run_loop.h"
Bryan McQuade 2017/04/26 16:04:34 can remove this include
lpy 2017/04/27 10:58:35 Done.
#include "base/test/histogram_tester.h"
#include "base/time/time.h"
#include "chrome/browser/page_load_metrics/metrics_navigation_throttle.h"
@@ -167,10 +168,7 @@ class MetricsWebContentsObserverTest : public ChromeRenderViewHostTestHarness {
void SimulateTimingUpdate(const PageLoadTiming& timing,
content::RenderFrameHost* render_frame_host) {
- ASSERT_TRUE(observer_->OnMessageReceived(
- PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing,
- PageLoadMetadata()),
- render_frame_host));
+ observer_->OnTimingUpdated(render_frame_host, timing, PageLoadMetadata());
}
void AttachObserver() {

Powered by Google App Engine
This is Rietveld 408576698