[Page Load Metrics] PageLoadMetrics Mojofication.

chrome/common/chrome_features.h

Index: chrome/common/chrome_features.h
diff --git a/chrome/common/chrome_features.h b/chrome/common/chrome_features.h
index 7c5f8c7c9f59d298dbe9df61f4f798ff3aea081e..514432bb7415ddc63556ba434674874922aba15d 100644
--- a/chrome/common/chrome_features.h
+++ b/chrome/common/chrome_features.h
@@ -186,6 +186,8 @@ extern const base::Feature kEHVInputOnImeMenu;
 extern const base::Feature kCrosCompUpdates;
 #endif  // defined(OS_CHROMEOS)
 
+extern const base::Feature kPageLoadMetricsMojofication;

[Bryan McQuade, 2017/04/24 21:50:55]

does this need to be declared in chrome_features.h? Can it instead be declared
in the class that wants to detect whether this feature is enabled/disabled?
that's the more typical way I've seen features like this declared. see for
example kDelayNavigationFeature in
https://cs.chromium.org/chromium/src/chrome/browser/page_load_metrics/experim...

[lpy, 2017/04/25 09:03:37]

It's declared here because both renderer/ and browser/ need to use it, renderer
checks to decide which IPC it should use to send data, and browser uses it for
browser test only.

[Bryan McQuade, 2017/04/25 15:41:14]

Ah, I see, thanks! I'm ok with putting this here, though I'm also open to moving
it somewhere under chrome/common/page_load_metrics/ if there's a logical place
there.

[lpy, 2017/04/26 14:18:41]

Acknowledged.

+
 bool PrefServiceEnabled();
 
 // DON'T ADD RANDOM STUFF HERE. Put it in the main section above in