Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2439)

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Add browser test for mojofication. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
index 72e61bb4648c412132d1c6c68e526b3f61dede13..716d13e56d380f3e1fe7c0f0c7e9a47bfa15d5a5 100644
--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
@@ -9,8 +9,10 @@
#include "base/macros.h"
#include "base/memory/ptr_util.h"
+#include "base/run_loop.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_embedder_interface.h"
#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
+#include "chrome/common/page_load_metrics/page_load_metrics.mojom.h"
#include "chrome/common/page_load_metrics/page_load_metrics_messages.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/web_contents.h"
@@ -146,6 +148,14 @@ void PageLoadMetricsObserverTestHarness::SimulateTimingAndMetadataUpdate(
observer_->OnMessageReceived(PageLoadMetricsMsg_TimingUpdated(
Bryan McQuade 2017/04/25 15:41:14 same thing here - let's invoke OnTimingUpdated dir
lpy 2017/04/26 14:18:40 Done.
observer_->routing_id(), timing, metadata),
web_contents()->GetMainFrame());
+ observer_->page_load_metrics_binding_for_testing()
+ .SetCurrentTargetFrameForTesting(web_contents()->GetMainFrame());
+ mojo::Binding<page_load_metrics::mojom::PageLoadMetrics> binding(observer_);
+ mojom::PageLoadMetricsPtr ptr;
+ mojom::PageLoadMetricsRequest request = MakeRequest(&ptr);
+ binding.Bind(std::move(request));
+ ptr->UpdateTiming(timing, metadata);
+ base::RunLoop().RunUntilIdle();
}
void PageLoadMetricsObserverTestHarness::SimulateLoadedResource(

Powered by Google App Engine
This is Rietveld 408576698