Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: update Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "chrome/common/page_load_metrics/page_load_metrics.mojom.h"
11 #include "chrome/common/page_load_metrics/page_load_timing.h" 12 #include "chrome/common/page_load_metrics/page_load_timing.h"
13 #include "chrome/renderer/page_load_metrics/page_timing_sender.h"
12 #include "content/public/renderer/render_frame_observer.h" 14 #include "content/public/renderer/render_frame_observer.h"
13 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h" 15 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
14 16
15 namespace base { 17 namespace base {
16 class Timer; 18 class Timer;
17 } // namespace base 19 } // namespace base
18 20
19 namespace page_load_metrics { 21 namespace page_load_metrics {
20 22
21 class PageTimingMetricsSender; 23 class PageTimingMetricsSender;
22 24
23 // MetricsRenderFrameObserver observes RenderFrame notifications, and sends page 25 // MetricsRenderFrameObserver observes RenderFrame notifications, and sends page
24 // load timing information to the browser process over IPC. A 26 // load timing information to the browser process over IPC. A
25 // MetricsRenderFrameObserver is instantiated for each frame (main frames and 27 // MetricsRenderFrameObserver is instantiated for each frame (main frames and
26 // child frames). MetricsRenderFrameObserver dispatches timing and metadata 28 // child frames). MetricsRenderFrameObserver dispatches timing and metadata
27 // updates for main frames, but only metadata updates for child frames. 29 // updates for main frames, but only metadata updates for child frames.
28 class MetricsRenderFrameObserver : public content::RenderFrameObserver { 30 class MetricsRenderFrameObserver : public content::RenderFrameObserver,
31 public PageTimingSender {
29 public: 32 public:
30 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame); 33 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame);
31 ~MetricsRenderFrameObserver() override; 34 ~MetricsRenderFrameObserver() override;
32 35
36 // PageTimingSender implementation
37 void SendTiming(const PageLoadTiming& timing,
38 const PageLoadMetadata& metadata) override;
39
33 // RenderFrameObserver implementation 40 // RenderFrameObserver implementation
34 void DidChangePerformanceTiming() override; 41 void DidChangePerformanceTiming() override;
35 void DidObserveLoadingBehavior( 42 void DidObserveLoadingBehavior(
36 blink::WebLoadingBehaviorFlag behavior) override; 43 blink::WebLoadingBehaviorFlag behavior) override;
37 void DidCommitProvisionalLoad(bool is_new_navigation, 44 void DidCommitProvisionalLoad(bool is_new_navigation,
38 bool is_same_document_navigation) override; 45 bool is_same_document_navigation) override;
39 void OnDestruct() override; 46 void OnDestruct() override;
40 47
41 // Invoked when a frame is going away. This is our last chance to send IPCs 48 // Invoked when a frame is going away. This is our last chance to send IPCs
42 // before being destroyed. 49 // before being destroyed.
43 void FrameDetached() override; 50 void FrameDetached() override;
44 51
45 private: 52 private:
46 // Will be null when we're not actively sending metrics.
47 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
48
49 void SendMetrics(); 53 void SendMetrics();
50 virtual bool ShouldSendMetrics() const; 54 virtual bool ShouldSendMetrics() const;
51 virtual PageLoadTiming GetTiming() const; 55 virtual PageLoadTiming GetTiming() const;
52 virtual std::unique_ptr<base::Timer> CreateTimer() const; 56 virtual std::unique_ptr<base::Timer> CreateTimer() const;
53 virtual bool HasNoRenderFrame() const; 57 virtual bool HasNoRenderFrame() const;
54 virtual bool IsMainFrame() const; 58 virtual bool IsMainFrame() const;
55 59
60 // Will be null when we're not actively sending metrics.
61 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
62 // Use associated interface to make sure mojo messages are ordered with regard
63 // to legacy IPC messages.
64 mojom::PageLoadMetricsAssociatedPtr page_load_metrics_;
65
56 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver); 66 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);
57 }; 67 };
58 68
59 } // namespace page_load_metrics 69 } // namespace page_load_metrics
60 70
61 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_ 71 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698