Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/common/page_load_metrics/page_load_metrics.mojom

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Addressed comments, remove unnecessary RunUntilIdle, call OnTimingUpdated directly in unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 module page_load_metrics.mojom;
6
7 import "mojo/common/time.mojom";
8
9 // See comments in page_load_timing.h for details on each field.
10
11 struct DocumentTiming {
12 mojo.common.mojom.TimeDelta? dom_content_loaded_event_start;
13 mojo.common.mojom.TimeDelta? load_event_start;
14 mojo.common.mojom.TimeDelta? first_layout;
15 };
16
17 struct PaintTiming {
18 mojo.common.mojom.TimeDelta? first_paint;
19 mojo.common.mojom.TimeDelta? first_text_paint;
20 mojo.common.mojom.TimeDelta? first_image_paint;
21 mojo.common.mojom.TimeDelta? first_contentful_paint;
22 mojo.common.mojom.TimeDelta? first_meaningful_paint;
23 };
24
25 struct ParseTiming {
26 mojo.common.mojom.TimeDelta? parse_start;
27 mojo.common.mojom.TimeDelta? parse_stop;
28 mojo.common.mojom.TimeDelta? parse_blocked_on_script_load_duration;
29 mojo.common.mojom.TimeDelta? parse_blocked_on_script_load_from_document_write_ duration;
30 mojo.common.mojom.TimeDelta? parse_blocked_on_script_execution_duration;
31 mojo.common.mojom.TimeDelta? parse_blocked_on_script_execution_from_document_w rite_duration;
32 };
33
34 struct StyleSheetTiming {
35 mojo.common.mojom.TimeDelta? author_style_sheet_parse_duration_before_fcp;
36 mojo.common.mojom.TimeDelta? update_style_duration_before_fcp;
37 };
38
39 struct PageLoadTiming {
40 mojo.common.mojom.Time navigation_start;
41 mojo.common.mojom.TimeDelta? response_start;
42 DocumentTiming document_timing;
Bryan McQuade 2017/04/26 15:24:22 In looking at the generated code for this struct i
Ken Rockot(use gerrit already) 2017/04/26 15:28:45 Yes, this is the point of typemapping. You typemap
Bryan McQuade 2017/04/26 20:41:51 Based on other discussions on the thread, I'm incl
lpy 2017/04/27 10:58:35 I prefer not to do it. I don't see clear benefit e
Bryan McQuade 2017/04/27 15:42:32 Ok. Just so I better understand, if we were writin
lpy 2017/05/05 17:49:30 Acknowledged.
43 PaintTiming paint_timing;
44 ParseTiming parse_timing;
45 StyleSheetTiming style_sheet_timing;
46 };
47
48 struct PageLoadMetadata {
49 int32 behavior_flags;
50 };
51
52 // Sent from renderer to browser process when the PageLoadTiming for the
53 // associated frame changed.
54 interface PageLoadMetrics {
55 UpdateTiming(PageLoadTiming page_load_timing, PageLoadMetadata page_load_metad ata);
Bryan McQuade 2017/04/26 15:24:22 similarly, the generated code appears to be using
lpy 2017/05/05 17:49:30 Acknowledged.
56 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698