[Page Load Metrics] PageLoadMetrics Mojofication.

chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
 
 #include <algorithm>
 #include <ostream>
 #include <string>
 #include <utility>
@@ skipping 46 matching lines @@
 
   return UserInitiatedInfo::RenderInitiated(
       navigation_handle->HasUserGesture(),
       committed_load &&
           committed_load->input_tracker()->FindAndConsumeInputEventsBefore(
               navigation_handle->NavigationStart()));
 }
 
 }  // namespace
 
-// static
 MetricsWebContentsObserver::MetricsWebContentsObserver(
     content::WebContents* web_contents,
     std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface)
     : content::WebContentsObserver(web_contents),
       in_foreground_(false),
       embedder_interface_(std::move(embedder_interface)),
-      has_navigated_(false) {
+      has_navigated_(false),
+      page_load_metrics_binding_(web_contents, this) {
   RegisterInputEventObserver(web_contents->GetRenderViewHost());
 }
 
+// static
 MetricsWebContentsObserver* MetricsWebContentsObserver::CreateForWebContents(
     content::WebContents* web_contents,
     std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface) {
   DCHECK(web_contents);
 
   MetricsWebContentsObserver* metrics = FromWebContents(web_contents);
   if (!metrics) {
     metrics = new MetricsWebContentsObserver(web_contents,
                                              std::move(embedder_interface));
     web_contents->SetUserData(UserDataKey(), metrics);
@@ skipping 485 matching lines @@
     // updates.
     if (!timing.IsEmpty())
       RecordInternalError(ERR_TIMING_IPC_FROM_SUBFRAME);
     committed_load_->UpdateChildFrameMetadata(metadata);
     return;
   }
 
   committed_load_->UpdateTiming(timing, metadata);
 }
 
+void MetricsWebContentsObserver::UpdateTiming(
+    const PageLoadTiming& timing,
+    const PageLoadMetadata& metadata) {
+  content::RenderFrameHost* render_frame_host =
+      page_load_metrics_binding_.GetCurrentTargetFrame();
+  OnTimingUpdated(render_frame_host, timing, metadata);

[Zhen Wang, 2017/04/19 18:49:54]

This is using the same timing update function as the old IPC, right? How do we
distinguish which data comes from which?

[Zhen Wang, 2017/04/19 18:56:31]

I just realized that you may not need to do any special thing on the browser
side, if you use the flag to toggle between IPC and Mojo. See the renderer side
comment for details.

+}
+
 bool MetricsWebContentsObserver::ShouldTrackNavigation(
     content::NavigationHandle* navigation_handle) const {
   DCHECK(navigation_handle->IsInMainFrame());
   DCHECK(!navigation_handle->HasCommitted() ||
          !navigation_handle->IsSameDocument());
 
   return BrowserPageTrackDecider(embedder_interface_.get(), web_contents(),
                                  navigation_handle).ShouldTrack();
 }
 
 }  // namespace page_load_metrics