Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: milo/appengine/buildbucket/common.go

Issue 2823413002: Milo buildbot: Add in the rest of the blame/commits information. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbucket/common.go
diff --git a/milo/appengine/buildbucket/common.go b/milo/appengine/buildbucket/common.go
index c10d192df5c45e74620f8582246f910921dad6a4..8231bf1f473203221808939ef76beb236ed9c70d 100644
--- a/milo/appengine/buildbucket/common.go
+++ b/milo/appengine/buildbucket/common.go
@@ -113,8 +113,10 @@ func getChangeList(
case "rietveld":
if prop.RietveldURL != "" && prop.Issue != 0 {
result = &resp.Commit{
- Revision: resultDetails.Properties.GotRevision,
- RequestRevision: prop.Revision,
+ // TODO(hinoka): Figure out the full URL for these revisions, add it
+ // to the URL field.
+ Revision: &resp.Link{Label: resultDetails.Properties.GotRevision},
+ RequestRevision: &resp.Link{Label: prop.Revision},
Changelist: &resp.Link{
Label: fmt.Sprintf("Rietveld CL %d", prop.Issue),
URL: fmt.Sprintf("%s/%d/#ps%d", prop.RietveldURL, prop.Issue, prop.PatchSet),

Powered by Google App Engine
This is Rietveld 408576698