Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 282333003: Cast: Make the udp proxy actually work for v1 mirroring (Closed)

Created:
6 years, 7 months ago by hubbe
Modified:
6 years, 7 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Make the udp proxy actually work for v1 mirroring Previously it would not set the return address properly, hopefully it will work now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272680

Patch Set 1 #

Patch Set 2 : fixed and formatted, hopefully #

Patch Set 3 : tested and works #

Total comments: 2

Patch Set 4 : added missing initializer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -61 lines) Patch
M media/cast/test/utility/udp_proxy.cc View 1 2 3 6 chunks +78 lines, -61 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hubbe
6 years, 7 months ago (2014-05-23 21:54:10 UTC) #1
miu
https://codereview.chromium.org/282333003/diff/40001/media/cast/test/utility/udp_proxy.cc File media/cast/test/utility/udp_proxy.cc (right): https://codereview.chromium.org/282333003/diff/40001/media/cast/test/utility/udp_proxy.cc#newcode562 media/cast/test/utility/udp_proxy.cc:562: bool blocked_; Need to initialize this to false in ...
6 years, 7 months ago (2014-05-23 22:20:43 UTC) #2
hubbe
https://codereview.chromium.org/282333003/diff/40001/media/cast/test/utility/udp_proxy.cc File media/cast/test/utility/udp_proxy.cc (right): https://codereview.chromium.org/282333003/diff/40001/media/cast/test/utility/udp_proxy.cc#newcode562 media/cast/test/utility/udp_proxy.cc:562: bool blocked_; On 2014/05/23 22:20:43, miu wrote: > Need ...
6 years, 7 months ago (2014-05-23 22:23:47 UTC) #3
miu
lgtm
6 years, 7 months ago (2014-05-23 22:27:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/282333003/60001
6 years, 7 months ago (2014-05-23 22:29:26 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 01:51:23 UTC) #6
Message was sent while issue was closed. 
Change committed as 272680

Powered by Google App Engine
This is Rietveld 408576698