Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 2823293002: deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support for QUIC v34. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client_session_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index 3c78e671f7a43630a134112aa6e4ceb27b8dfca7..8fc56573620088aef8873b387c2719a2224285e4 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -528,9 +528,8 @@ TEST_F(QuicDispatcherTest, TooBigSeqNoPacketToTimeWaitListManager) {
}
TEST_F(QuicDispatcherTest, SupportedVersionsChangeInFlight) {
- static_assert(arraysize(kSupportedQuicVersions) == 6u,
+ static_assert(arraysize(kSupportedQuicVersions) == 5u,
"Supported versions out of sync");
- FLAGS_quic_reloadable_flag_quic_disable_version_34 = false;
FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 = true;
FLAGS_quic_reloadable_flag_quic_enable_version_37 = true;
FLAGS_quic_reloadable_flag_quic_enable_version_38 = true;
@@ -624,32 +623,6 @@ TEST_F(QuicDispatcherTest, SupportedVersionsChangeInFlight) {
ProcessPacket(client_address, connection_id, true, QUIC_VERSION_35,
SerializeCHLO(), PACKET_8BYTE_CONNECTION_ID,
PACKET_6BYTE_PACKET_NUMBER, 1);
-
- // Turn off version 34.
- FLAGS_quic_reloadable_flag_quic_disable_version_34 = true;
- ++connection_id;
- EXPECT_CALL(*dispatcher_, CreateQuicSession(connection_id, client_address))
- .Times(0);
- ProcessPacket(client_address, connection_id, true, QUIC_VERSION_34,
- SerializeCHLO(), PACKET_8BYTE_CONNECTION_ID,
- PACKET_6BYTE_PACKET_NUMBER, 1);
-
- // Turn on version 34.
- FLAGS_quic_reloadable_flag_quic_disable_version_34 = false;
- ++connection_id;
- EXPECT_CALL(*dispatcher_, CreateQuicSession(connection_id, client_address))
- .WillOnce(testing::Return(CreateSession(
- dispatcher_.get(), config_, connection_id, client_address,
- &mock_helper_, &mock_alarm_factory_, &crypto_config_,
- QuicDispatcherPeer::GetCache(dispatcher_.get()), &session1_)));
- EXPECT_CALL(*reinterpret_cast<MockQuicConnection*>(session1_->connection()),
- ProcessUdpPacket(_, _, _))
- .WillOnce(testing::WithArgs<2>(
- Invoke(CreateFunctor(&QuicDispatcherTest::ValidatePacket,
- base::Unretained(this), connection_id))));
- ProcessPacket(client_address, connection_id, true, QUIC_VERSION_34,
- SerializeCHLO(), PACKET_8BYTE_CONNECTION_ID,
- PACKET_6BYTE_PACKET_NUMBER, 1);
}
// Enables mocking of the handshake-confirmation for stateless rejects.
« no previous file with comments | « net/tools/quic/quic_client_session_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698