Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: net/quic/core/quic_version_manager_test.cc

Issue 2823293002: deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support for QUIC v34. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_version_manager.cc ('k') | net/quic/core/quic_versions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_version_manager_test.cc
diff --git a/net/quic/core/quic_version_manager_test.cc b/net/quic/core/quic_version_manager_test.cc
index bd259cb6920836df773d27a9638796d45eb3b282..e80cbffa73038c63e3974c6204f73bf2dffb7271 100644
--- a/net/quic/core/quic_version_manager_test.cc
+++ b/net/quic/core/quic_version_manager_test.cc
@@ -19,7 +19,6 @@ TEST(QuicVersionManagerTest, QuicVersionManager) {
FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 = false;
FLAGS_quic_reloadable_flag_quic_enable_version_38 = false;
FLAGS_quic_reloadable_flag_quic_enable_version_37 = false;
- FLAGS_quic_reloadable_flag_quic_disable_version_34 = false;
QuicVersionManager manager(AllSupportedVersions());
EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
manager.GetSupportedVersions());
@@ -27,42 +26,37 @@ TEST(QuicVersionManagerTest, QuicVersionManager) {
FLAGS_quic_reloadable_flag_quic_enable_version_36_v3 = true;
EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
manager.GetSupportedVersions());
- ASSERT_EQ(3u, manager.GetSupportedVersions().size());
+ ASSERT_EQ(2u, manager.GetSupportedVersions().size());
EXPECT_EQ(QUIC_VERSION_36, manager.GetSupportedVersions()[0]);
EXPECT_EQ(QUIC_VERSION_35, manager.GetSupportedVersions()[1]);
- EXPECT_EQ(QUIC_VERSION_34, manager.GetSupportedVersions()[2]);
FLAGS_quic_reloadable_flag_quic_enable_version_37 = true;
EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
manager.GetSupportedVersions());
- ASSERT_EQ(4u, manager.GetSupportedVersions().size());
+ ASSERT_EQ(3u, manager.GetSupportedVersions().size());
EXPECT_EQ(QUIC_VERSION_37, manager.GetSupportedVersions()[0]);
EXPECT_EQ(QUIC_VERSION_36, manager.GetSupportedVersions()[1]);
EXPECT_EQ(QUIC_VERSION_35, manager.GetSupportedVersions()[2]);
- EXPECT_EQ(QUIC_VERSION_34, manager.GetSupportedVersions()[3]);
FLAGS_quic_reloadable_flag_quic_enable_version_38 = true;
EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
manager.GetSupportedVersions());
- ASSERT_EQ(5u, manager.GetSupportedVersions().size());
+ ASSERT_EQ(4u, manager.GetSupportedVersions().size());
EXPECT_EQ(QUIC_VERSION_38, manager.GetSupportedVersions()[0]);
EXPECT_EQ(QUIC_VERSION_37, manager.GetSupportedVersions()[1]);
EXPECT_EQ(QUIC_VERSION_36, manager.GetSupportedVersions()[2]);
EXPECT_EQ(QUIC_VERSION_35, manager.GetSupportedVersions()[3]);
- EXPECT_EQ(QUIC_VERSION_34, manager.GetSupportedVersions()[4]);
base::SetFlag(&FLAGS_quic_enable_version_39, true);
EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
manager.GetSupportedVersions());
- ASSERT_EQ(6u, manager.GetSupportedVersions().size());
+ ASSERT_EQ(5u, manager.GetSupportedVersions().size());
EXPECT_EQ(QUIC_VERSION_39, manager.GetSupportedVersions()[0]);
EXPECT_EQ(QUIC_VERSION_38, manager.GetSupportedVersions()[1]);
EXPECT_EQ(QUIC_VERSION_37, manager.GetSupportedVersions()[2]);
EXPECT_EQ(QUIC_VERSION_36, manager.GetSupportedVersions()[3]);
EXPECT_EQ(QUIC_VERSION_35, manager.GetSupportedVersions()[4]);
- EXPECT_EQ(QUIC_VERSION_34, manager.GetSupportedVersions()[5]);
- FLAGS_quic_reloadable_flag_quic_disable_version_34 = true;
EXPECT_EQ(FilterSupportedVersions(AllSupportedVersions()),
manager.GetSupportedVersions());
ASSERT_EQ(5u, manager.GetSupportedVersions().size());
« no previous file with comments | « net/quic/core/quic_version_manager.cc ('k') | net/quic/core/quic_versions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698