Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: net/quic/core/quic_server_session_base_test.cc

Issue 2823293002: deprecate -FLAGS_quic_reloadable_flag_quic_disable_version_34 and remove support for QUIC v34. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_headers_stream_test.cc ('k') | net/quic/core/quic_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_server_session_base_test.cc
diff --git a/net/quic/core/quic_server_session_base_test.cc b/net/quic/core/quic_server_session_base_test.cc
index 800289185752560a9d689ed89f871834378b6d10..b50515375c4f41d883368c524685a4e237da2260 100644
--- a/net/quic/core/quic_server_session_base_test.cc
+++ b/net/quic/core/quic_server_session_base_test.cc
@@ -193,11 +193,7 @@ TEST_P(QuicServerSessionBaseTest, ServerPushDisabledByDefault) {
session_->config()->HasReceivedConnectionOptions() &&
ContainsQuicTag(session_->config()->ReceivedConnectionOptions(), kSPSH));
session_->OnConfigNegotiated();
- if (GetParam() <= QUIC_VERSION_34) {
- EXPECT_FALSE(session_->server_push_enabled());
- } else {
- EXPECT_TRUE(session_->server_push_enabled());
- }
+ EXPECT_TRUE(session_->server_push_enabled());
}
TEST_P(QuicServerSessionBaseTest, CloseStreamDueToReset) {
@@ -277,10 +273,6 @@ TEST_P(QuicServerSessionBaseTest, MaxOpenStreams) {
// streams. The server accepts slightly more than the negotiated stream limit
// to deal with rare cases where a client FIN/RST is lost.
- if (GetParam() <= QUIC_VERSION_34) {
- EXPECT_EQ(kMaxStreamsForTest, session_->max_open_incoming_streams());
- }
-
// The slightly increased stream limit is set during config negotiation. It
// is either an increase of 10 over negotiated limit, or a fixed percentage
// scaling, whichever is larger. Test both before continuing.
@@ -319,10 +311,6 @@ TEST_P(QuicServerSessionBaseTest, MaxAvailableStreams) {
// streams available. The server accepts slightly more than the negotiated
// stream limit to deal with rare cases where a client FIN/RST is lost.
- if (GetParam() <= QUIC_VERSION_34) {
- // The slightly increased stream limit is set during config negotiation.
- EXPECT_EQ(kMaxStreamsForTest, session_->max_open_incoming_streams());
- }
session_->OnConfigNegotiated();
const size_t kAvailableStreamLimit = session_->MaxAvailableStreams();
EXPECT_EQ(
« no previous file with comments | « net/quic/core/quic_headers_stream_test.cc ('k') | net/quic/core/quic_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698