Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: content/browser/download/download_stats.h

Issue 2823273004: Add new UMA stats for parallelizable download (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_stats.h
diff --git a/content/browser/download/download_stats.h b/content/browser/download/download_stats.h
index a7d706a9155af47e2b638b52ea6688eb3a17e199..f731029736f8ed3393646315536c65a804633fa8 100644
--- a/content/browser/download/download_stats.h
+++ b/content/browser/download/download_stats.h
@@ -195,6 +195,7 @@ void RecordDownloadCompleted(const base::TimeTicks& start,
void RecordDownloadInterrupted(DownloadInterruptReason reason,
int64_t received,
int64_t total,
+ bool is_parallelizable,
bool uses_parallel_requests);
// Record that a download has been classified as malicious.
@@ -254,8 +255,9 @@ void RecordFileBandwidth(size_t length,
base::TimeDelta disk_write_time,
base::TimeDelta elapsed_time);
-// Increment one of the count for parallel download.
-void RecordParallelDownloadCount(DownloadCountTypes type);
+// Increment one of the count for parallelizable download.
+void RecordParallelizableDownloadCount(DownloadCountTypes type,
+ bool uses_parallel_requests);
// Records the actual total number of requests sent for a parallel download,
// including the initial request.
@@ -264,13 +266,15 @@ void RecordParallelDownloadRequestCount(int request_count);
// Records if each byte stream is successfully added to download sink.
void RecordParallelDownloadAddStreamSuccess(bool success);
-// Records the bandwidth for parallel download and estimates the saved time at
-// the file end. Does not count in any hash computation or file open/close time.
-void RecordParallelDownloadStats(
+// Records the bandwidth for parallelizable download and estimates the saved
+// time at the file end. Does not count in any hash computation or file
+// open/close time.
+void RecordParallelizableDownloadStats(
size_t bytes_downloaded_with_parallel_streams,
base::TimeDelta time_with_parallel_streams,
size_t bytes_downloaded_without_parallel_streams,
- base::TimeDelta time_without_parallel_streams);
+ base::TimeDelta time_without_parallel_streams,
+ bool uses_parallel_requests);
// Records the parallel download creation counts and the reasons why the
// download falls back to non-parallel download.

Powered by Google App Engine
This is Rietveld 408576698