Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: content/browser/download/download_job.h

Issue 2823273004: Add new UMA stats for parallelizable download (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_JOB_H_ 5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_JOB_H_
6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_JOB_H_ 6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_JOB_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/browser/byte_stream.h" 10 #include "content/browser/byte_stream.h"
(...skipping 24 matching lines...) Expand all
35 35
36 // Return the WebContents associated with the download. Usually used to 36 // Return the WebContents associated with the download. Usually used to
37 // associate a browser window for any UI that needs to be displayed to the 37 // associate a browser window for any UI that needs to be displayed to the
38 // user. 38 // user.
39 // Or return nullptr if the download is not associated with an active 39 // Or return nullptr if the download is not associated with an active
40 // WebContents. 40 // WebContents.
41 virtual WebContents* GetWebContents() const = 0; 41 virtual WebContents* GetWebContents() const = 0;
42 42
43 // Returns whether the download uses parallel requests. 43 // Returns whether the download uses parallel requests.
44 virtual bool UsesParallelRequests() const; 44 virtual bool UsesParallelRequests() const;
45 virtual bool IsParallelizable() const;
xingliu 2017/04/19 02:18:11 nit: Can we add a comment here.
qinmin 2017/04/19 22:42:33 Done.
45 46
46 protected: 47 protected:
47 void StartDownload() const; 48 void StartDownload() const;
48 void Interrupt(DownloadInterruptReason reason); 49 void Interrupt(DownloadInterruptReason reason);
49 50
50 // Add a byte stream to the download sink. Return false if we start to 51 // Add a byte stream to the download sink. Return false if we start to
51 // destroy download file. 52 // destroy download file.
52 bool AddByteStream(std::unique_ptr<ByteStreamReader> stream_reader, 53 bool AddByteStream(std::unique_ptr<ByteStreamReader> stream_reader,
53 int64_t offset, 54 int64_t offset,
54 int64_t length); 55 int64_t length);
55 56
56 // Sets the potential length of the file. 57 // Sets the potential length of the file.
57 void SetPotentialFileLength(int64_t length); 58 void SetPotentialFileLength(int64_t length);
58 59
59 DownloadItemImpl* download_item_; 60 DownloadItemImpl* download_item_;
60 61
61 private: 62 private:
62 // If the download progress is paused by the user. 63 // If the download progress is paused by the user.
63 bool is_paused_; 64 bool is_paused_;
64 65
65 DISALLOW_COPY_AND_ASSIGN(DownloadJob); 66 DISALLOW_COPY_AND_ASSIGN(DownloadJob);
66 }; 67 };
67 68
68 } // namespace content 69 } // namespace content
69 70
70 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_JOB_H_ 71 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_JOB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698