Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: runtime/vm/object_test.cc

Issue 2823253005: Fix #28740 demangle constructors in stack traces (A.A becomes new A) REDO (Closed)
Patch Set: Don't recurse in QualifiedName, just check the ending function kind for ctor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/profiler_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index a9fa357ca9efd6d2d2e3a71afdd2715fb1d5d137..07b9473cbf41732e794e75219f065780a753e2c4 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -3323,14 +3323,14 @@ TEST_CASE(StackTraceFormat) {
"Unhandled exception:\n"
"MyException\n"
"#0 baz (test-lib:2:3)\n"
- "#1 _OtherClass._OtherClass._named (test-lib:7:5)\n"
+ "#1 new _OtherClass._named (test-lib:7:5)\n"
"#2 globalVar= (test-lib:12:7)\n"
"#3 _bar (test-lib:16:3)\n"
"#4 MyClass.field (test-lib:25:5)\n"
"#5 MyClass.foo.fooHelper (test-lib:30:7)\n"
"#6 MyClass.foo (test-lib:32:14)\n"
- "#7 MyClass.MyClass.<anonymous closure> (test-lib:21:12)\n"
- "#8 MyClass.MyClass (test-lib:21:18)\n"
+ "#7 new MyClass.<anonymous closure> (test-lib:21:12)\n"
+ "#8 new MyClass (test-lib:21:18)\n"
"#9 main.<anonymous closure> (test-lib:37:14)\n"
"#10 main (test-lib:37:24)");
}
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/profiler_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698