Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: content/child/ftp_directory_listing_response_delegate.h

Issue 2823173003: Improve error handling in FtpDirectoryListingResponseDelegate. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/ftp_directory_listing_response_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/ftp_directory_listing_response_delegate.h
diff --git a/content/child/ftp_directory_listing_response_delegate.h b/content/child/ftp_directory_listing_response_delegate.h
index 0d1a61f3e979cb27cdfee44180742cc0200a26bf..319cad0c4376b05846a00516b991b318d6275635 100644
--- a/content/child/ftp_directory_listing_response_delegate.h
+++ b/content/child/ftp_directory_listing_response_delegate.h
@@ -11,6 +11,7 @@
#include <string>
#include "base/macros.h"
+#include "base/strings/string_piece.h"
#include "third_party/WebKit/public/platform/WebURLResponse.h"
namespace blink {
@@ -31,14 +32,14 @@ class FtpDirectoryListingResponseDelegate {
// The request has been canceled, so stop making calls to the client.
void Cancel();
- // Passed through from ResourceHandleInternal
+ // Called from WebURLLoaderImpl.
void OnReceivedData(const char* data, int data_len);
- void OnCompletedRequest();
+ void OnCompletedRequest(int error_code);
private:
void Init(const GURL& response_url);
- void SendDataToClient(const std::string& data);
+ void SendDataToClient(base::StringPiece data);
// Pointers to the client and associated loader so we can make callbacks as
// we parse pieces of data.
« no previous file with comments | « no previous file | content/child/ftp_directory_listing_response_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698