Port some AOM tests from LayoutTests to SimTests.

third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp

Index: third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp b/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..6928662cd82303014b2727c09dc0040d3d8293f8
--- /dev/null
+++ b/third_party/WebKit/Source/web/tests/AccessibilityObjectModelTest.cpp
@@ -0,0 +1,69 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/html/HTMLBodyElement.h"
+#include "modules/accessibility/AXObjectCacheImpl.h"
+#include "web/tests/sim/SimRequest.h"
+#include "web/tests/sim/SimTest.h"
+
+namespace blink {
+
+namespace {
+
+class AccessibilityObjectModelTest : public SimTest {

[aboxhall, 2017/04/18 05:43:16]

If this is ported, what was the original?

[dmazzoni, 2017/04/18 15:44:00]

The three tests here just duplicate existing tests from:

LayoutTests/accessibility/aom.html

I don't want to delete the layout tests, but the
plan is to switch to preferring SimTests, while
maintaining existing layout tests and still using them
on occasion when they're a better fit for a
particular test.

+ public:
+  AccessibilityObjectModelTest() {
+    RuntimeEnabledFeatures::setAccessibilityObjectModelEnabled(true);
+  }
+
+ protected:
+  AXObjectCacheImpl* AXObjectCache() {
+    GetDocument().GetSettings()->SetAccessibilityEnabled(true);
+    return static_cast<AXObjectCacheImpl*>(GetDocument().AxObjectCache());
+  }
+};
+
+TEST_F(AccessibilityObjectModelTest, DOMElementsHaveAnAccessibleNode) {
+  SimRequest main_resource("https://example.com/", "text/html");
+  LoadURL("https://example.com/");
+  main_resource.Complete("<button id=\"button\">Click me</button>");

[esprehn, 2017/04/20 19:54:06]

id=button, no quotes are needed and it avoids the escaping

[dmazzoni, 2017/04/21 00:07:35]

Done.

+  RuntimeEnabledFeatures::setAccessibilityObjectModelEnabled(true);

[bokan, 2017/04/20 14:58:33]

You already set this to true in the constructor, right? Also, I think you should
prefer using ScopedRuntimeEnabledFeatureForTest
(https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/testi...)

[dmazzoni, 2017/04/21 00:07:34]

Done.

+
+  String result = ExecuteJavaScript(

[esprehn, 2017/04/20 19:54:06]

Just do this in C++,

auto* button = GetDocument().getElementById("button");
EXPECT_NE(nullptr, button->accesibleNode());

[dmazzoni, 2017/04/21 00:07:34]

Done.

+      "String(document.getElementById('button').accessibleNode)");
+  EXPECT_EQ("[object AccessibleNode]", result);
+}
+
+TEST_F(AccessibilityObjectModelTest, DOMTextNodesDoNotHaveAnAccessibleNode) {
+  SimRequest main_resource("https://example.com/", "text/html");
+  LoadURL("https://example.com/");
+  main_resource.Complete("<button id=\"button\">Click me</button>");

[esprehn, 2017/04/20 19:54:06]

the button is not needed, just do "Text node" ?

[dmazzoni, 2017/04/21 00:07:34]

Done.

+  RuntimeEnabledFeatures::setAccessibilityObjectModelEnabled(true);

[esprehn, 2017/04/20 19:54:06]

not needed

[dmazzoni, 2017/04/21 00:07:35]

Done.

+
+  String result = ExecuteJavaScript(

[esprehn, 2017/04/20 19:54:06]

Is there a reason not to just do

auto* text = GetDocument().createTextNode("example");
EXPECT_EQ(nullptr, text->accessibleNode());

?

[dmazzoni, 2017/04/21 00:07:35]

Because accessibleNode is not even defined on Node?

I'll just delete this test. It's only useful as a sanity test for the bindings.

+      "String(document.getElementById('button').firstChild.accessibleNode)");
+  EXPECT_EQ("undefined", result);
+}
+
+TEST_F(AccessibilityObjectModelTest, SetAccessibleNodeRole) {
+  SimRequest main_resource("https://example.com/", "text/html");
+  LoadURL("https://example.com/");
+  main_resource.Complete("<button id=\"button\">Click me</button>");
+  RuntimeEnabledFeatures::setAccessibilityObjectModelEnabled(true);
+
+  ExecuteJavaScript(
+      "document.getElementById('button').accessibleNode.role = 'slider';");

[esprehn, 2017/04/20 19:54:06]

auto* button = GetDocument().getElementById("button");
button->accessibleNode()->setRole("slider")

[dmazzoni, 2017/04/21 00:07:35]

Done.

+
+  Element* button = GetDocument().GetElementById("button");
+  EXPECT_TRUE(button);

[esprehn, 2017/04/20 19:54:06]

ASSERT_NE(nullptr, button)

the code would crash if this condition was false, so it's ASSERT not EXPECT,
also a more explicit comparison is usually preferred

[dmazzoni, 2017/04/21 00:07:35]

Done.

+  auto* cache = AXObjectCache();
+  EXPECT_TRUE(cache);
+
+  auto* axButton = cache->GetOrCreate(button);
+  EXPECT_EQ(kSliderRole, axButton->RoleValue());
+}
+
+}  // namespace
+
+}  // namespace blink