components/history/core/browser/thumbnail_database.h - Issue 2823093002: Make FaviconService::GetRawFaviconForPageURL() select the best candidate among all the icon types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/thumbnail_database.h

Issue 2823093002: Make FaviconService::GetRawFaviconForPageURL() select the best candidate among all the icon types (Closed)

Patch Set: Merge branch 'icon_type0' into icon_type Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/thumbnail_database.h

diff --git a/components/history/core/browser/thumbnail_database.h b/components/history/core/browser/thumbnail_database.h

index b277d0e6cf4bbff032a26f77ef68207f8e72a1e0..ec21369d43830d0025471da7bfc3c42dd1803a0d 100644

--- a/components/history/core/browser/thumbnail_database.h

+++ b/components/history/core/browser/thumbnail_database.h

@@ -165,10 +165,6 @@ class ThumbnailDatabase {

// not NULL.

// Returns true if there are icon mappings for the given page and icon types.

- // If |required_icon_types| contains multiple icon types and there is more

- // than one matched icon type in the database, icons of only a single type

- // will be returned in the priority of TOUCH_PRECOMPOSED_ICON, TOUCH_ICON,

- // and FAVICON.

// The matched icon mappings are returned in the |mapping_data| parameter if

// it is not NULL.

bool GetIconMappingsForPageURL(const GURL& page_url,