Issue 282303014: Add regression tests to ensure that IPC::Listener::OnBadMessageReceived is always called for all ca…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 282303014: Add regression tests to ensure that IPC::Listener::OnBadMessageReceived is always called for all ca… (Closed)

Created:
6 years, 7 months ago by jam

Modified:
6 years, 7 months ago

Reviewers:
Tom Sepez

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add regression tests to ensure that IPC::Listener::OnBadMessageReceived is always called for all cases, i.e. 1) using IPC::Channel directly 2) using IPC::ChannelProxy and the IPC is dispatched on the IO thread 2) using IPC::ChannelProxy and the IPC is dispatched on the listener thread R=tsepez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271915

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+228 lines, -103 lines)			Patch
M	content/browser/renderer_host/render_view_host_unittest.cc	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	ipc/ipc_channel_proxy_unittest.cc	View	10 chunks	+184 lines, -61 lines	0 comments	Download
A	ipc/ipc_channel_proxy_unittest_messages.h	View	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

I should have added these with yesterday's cl; better late than never :)

6 years, 7 months ago (2014-05-17 00:58:30 UTC) #1

lgtm

Expand Messages | Collapse Messages