Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 282303013: Remove differences in detecting logged in state between guest and regular user. (Closed)

Created:
6 years, 7 months ago by achuithb
Modified:
6 years, 7 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove differences in detecting logged in state between guest and regular user. BUG= TEST=trybot, manual. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271530

Patch Set 1 #

Total comments: 2

Patch Set 2 : tengs feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
achuithb
please review, Tim
6 years, 7 months ago (2014-05-16 23:34:19 UTC) #1
achuithb
On 2014/05/16 23:34:19, achuithb wrote: > please review, Tim ping, in case you missed it
6 years, 7 months ago (2014-05-19 18:34:15 UTC) #2
Tim Song
https://codereview.chromium.org/282303013/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/282303013/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py#newcode245 tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:245: # Workaround for crbug.com/374462. Why isn't this workaround needed ...
6 years, 7 months ago (2014-05-19 19:07:38 UTC) #3
achuithb
https://codereview.chromium.org/282303013/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/282303013/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py#newcode245 tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:245: # Workaround for crbug.com/374462. On 2014/05/19 19:07:39, Tim Song ...
6 years, 7 months ago (2014-05-19 19:17:02 UTC) #4
Tim Song
Okay that makes sense. Please add a comment explaining why the WAR isn't needed in ...
6 years, 7 months ago (2014-05-19 19:51:53 UTC) #5
achuithb
On 2014/05/19 19:51:53, Tim Song wrote: > Okay that makes sense. Please add a comment ...
6 years, 7 months ago (2014-05-20 00:44:37 UTC) #6
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 7 months ago (2014-05-20 00:44:55 UTC) #7
achuithb
The CQ bit was unchecked by achuith@chromium.org
6 years, 7 months ago (2014-05-20 00:44:57 UTC) #8
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 7 months ago (2014-05-20 01:34:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/282303013/20001
6 years, 7 months ago (2014-05-20 01:36:07 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 01:37:48 UTC) #11
Message was sent while issue was closed.
Change committed as 271530

Powered by Google App Engine
This is Rietveld 408576698