Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 282303006: Gallery.app: Fix the task list of the separated version of Gallery. (Closed)

Created:
6 years, 7 months ago by hirono
Modified:
6 years, 7 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Gallery.app: Fix the task list of the separated version of Gallery. This CL: * filters the task of Gallery.app itself. * allows the gallery.app to load task icons. BUG=358698 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271012

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M ui/file_manager/gallery/js/gallery.js View 1 chunk +7 lines, -1 line 0 comments Download
M ui/file_manager/gallery/manifest.json View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 7 months ago (2014-05-16 07:30:09 UTC) #1
mtomasz
LGTM FYI, this feature is obsolete, and I think there was a decision to remove ...
6 years, 7 months ago (2014-05-16 07:57:34 UTC) #2
hirono
On 2014/05/16 07:57:34, mtomasz wrote: > LGTM > > FYI, this feature is obsolete, and ...
6 years, 7 months ago (2014-05-16 08:19:03 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 7 months ago (2014-05-16 08:19:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/282303006/20001
6 years, 7 months ago (2014-05-16 08:19:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 11:23:06 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 14:43:31 UTC) #7
Message was sent while issue was closed.
Change committed as 271012

Powered by Google App Engine
This is Rietveld 408576698