Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

Issue 2823003003: Remove Compiler and JavaScriptBackend from field_visitor. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
index 7566a62487d7f662c9406f92603e5298353b94cc..1bdafa9156f8463743179cb06ea0a916bf3c3060 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
@@ -134,9 +134,14 @@ class Collector {
final onlyForRti = classesOnlyNeededForRti.contains(cls);
if (!onlyForRti) {
backend.mirrorsData.retainMetadataOfClass(cls);
- new FieldVisitor(compiler, namer, closedWorld).visitFields(cls, false,
- (FieldElement member, js.Name name, js.Name accessorName,
- bool needsGetter, bool needsSetter, bool needsCheckedSetter) {
+ new FieldVisitor(compiler.options, compiler.codegenWorldBuilder,
+ backend.nativeData, backend.mirrorsData, namer, closedWorld)
+ .visitFields(cls, false, (FieldElement member,
+ js.Name name,
+ js.Name accessorName,
+ bool needsGetter,
+ bool needsSetter,
+ bool needsCheckedSetter) {
bool needsAccessor = needsGetter || needsSetter;
if (needsAccessor &&
backend.mirrorsData.isMemberAccessibleByReflection(member)) {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698