ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

index a1118cfeb31a6487a4db94f0ef1e7ced2bd7e617..0c829ba2de1d8d6a9808b93a6a6449307f33905e 100644

--- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

+++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

@@ -1352,7 +1352,6 @@ bool DesktopDragDropClientAuraX11::IsValidDragImage(

// don't make another context if the window would just be displaying a mostly

// transparent image.

const SkBitmap* in_bitmap = image.bitmap();

- SkAutoLockPixels in_lock(*in_bitmap);

for (int y = 0; y < in_bitmap->height(); ++y) {

uint32_t* in_row = in_bitmap->getAddr32(0, y);