ui/gfx/ipc/skia/gfx_skia_param_traits.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/ipc/skia/gfx_skia_param_traits.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/ipc/skia/gfx_skia_param_traits.cc

diff --git a/ui/gfx/ipc/skia/gfx_skia_param_traits.cc b/ui/gfx/ipc/skia/gfx_skia_param_traits.cc

index 5b09529f5dba1f235580076a1400a15192c4f88a..4a361372a5008189560251593571a048bebc4f19 100644

--- a/ui/gfx/ipc/skia/gfx_skia_param_traits.cc

+++ b/ui/gfx/ipc/skia/gfx_skia_param_traits.cc

@@ -64,7 +64,6 @@ void ParamTraits<SkBitmap>::Write(base::Pickle* m, const SkBitmap& p) {

m->WriteData(reinterpret_cast<const char*>(&bmp_data),

static_cast<int>(fixed_size));

size_t pixel_size = p.getSize();

- SkAutoLockPixels p_lock(p);

m->WriteData(reinterpret_cast<const char*>(p.getPixels()),

static_cast<int>(pixel_size));

}