ui/gfx/android/java_bitmap.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/android/java_bitmap.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/android/java_bitmap.cc

diff --git a/ui/gfx/android/java_bitmap.cc b/ui/gfx/android/java_bitmap.cc

index 82f1bca46ecf60de9f131e2f266af3335743840d..df98913bbafe58670c65397ba37a433f94d6234b 100644

--- a/ui/gfx/android/java_bitmap.cc

+++ b/ui/gfx/android/java_bitmap.cc

@@ -74,7 +74,6 @@ ScopedJavaLocalRef<jobject> ConvertToJavaBitmap(const SkBitmap* skbitmap) {

(color_type == kN32_SkColorType));

ScopedJavaLocalRef<jobject> jbitmap = CreateJavaBitmap(

skbitmap->width(), skbitmap->height(), color_type);

- SkAutoLockPixels src_lock(*skbitmap);

JavaBitmap dst_lock(jbitmap);

void* src_pixels = skbitmap->getPixels();

void* dst_pixels = dst_lock.pixels();