third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« skia/public/interfaces/bitmap_skbitmap_struct_traits.cc ('K') | « third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

index 7c14717bf9c7e8a97f51c05b3ccd98957ad3dacd..6a76f3be319f876385f728a64e6cc83004a2ba9a 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp

@@ -76,8 +76,6 @@ static bool BitmapsEqual(sk_sp<const PaintRecord> record1,

SkBitmap bitmap1 = RecordToBitmap(record1);

SkBitmap bitmap2 = RecordToBitmap(record2);

- bitmap1.lockPixels();

- bitmap2.lockPixels();

int mismatch_count = 0;

const int kMaxMismatches = 10;

for (int y = 0; y < rect.height() && mismatch_count < kMaxMismatches; ++y) {

@@ -91,8 +89,6 @@ static bool BitmapsEqual(sk_sp<const PaintRecord> record1,

}

- bitmap1.unlockPixels();

- bitmap2.unlockPixels();

return !mismatch_count;

}