media/remoting/interstitial.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/remoting/interstitial.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/remoting/interstitial.cc

diff --git a/media/remoting/interstitial.cc b/media/remoting/interstitial.cc

index 2548a2d0decc862257db11266df51b62c74fb379..cd046a948a0ad58c2b2184123a567913945d94f0 100644

--- a/media/remoting/interstitial.cc

+++ b/media/remoting/interstitial.cc

@@ -152,7 +152,6 @@ scoped_refptr<VideoFrame> RenderInterstitialFrame(const SkBitmap& image,

PIXEL_FORMAT_I420, canvas_size, gfx::Rect(canvas_size), canvas_size,

base::TimeDelta());

if (video_frame) {

- SkAutoLockPixels pixel_lock(canvas_bitmap);

CopyRGBToVideoFrame(reinterpret_cast<uint8_t*>(canvas_bitmap.getPixels()),

canvas_bitmap.rowBytes(),

gfx::Rect(canvas_size.width(), canvas_size.height()),