extensions/browser/api/web_contents_capture_client.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_contents_capture_client.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/web_contents_capture_client.cc

diff --git a/extensions/browser/api/web_contents_capture_client.cc b/extensions/browser/api/web_contents_capture_client.cc

index 78ee2851a3f6c264e8fdb13388132b1e1689432a..98eb66791262d4f71bc595425398885cfe354ae3 100644

--- a/extensions/browser/api/web_contents_capture_client.cc

+++ b/extensions/browser/api/web_contents_capture_client.cc

@@ -91,7 +91,6 @@ bool WebContentsCaptureClient::EncodeBitmap(const SkBitmap& bitmap,

std::string* base64_result) {

DCHECK(base64_result);

std::vector<unsigned char> data;

- SkAutoLockPixels screen_capture_lock(bitmap);

const bool should_discard_alpha = !ClientAllowsTransparency();

bool encoded = false;

std::string mime_type;