content/shell/test_runner/test_runner_for_specific_view.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/test_runner/test_runner_for_specific_view.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/test_runner/test_runner_for_specific_view.cc

diff --git a/content/shell/test_runner/test_runner_for_specific_view.cc b/content/shell/test_runner/test_runner_for_specific_view.cc

index a2f283952455ccb2c4a74d07a7bcd56276bddb2d..cbd139b1d53620b70e371556029b54040d073fac 100644

--- a/content/shell/test_runner/test_runner_for_specific_view.cc

+++ b/content/shell/test_runner/test_runner_for_specific_view.cc

@@ -255,7 +255,6 @@ void TestRunnerForSpecificView::CapturePixelsCallback(

v8::Context::Scope context_scope(context);

v8::Local<v8::Value> argv[3];

- SkAutoLockPixels snapshot_lock(snapshot);

// Size can be 0 for cases where copyImageAt was called on position

// that doesn't have an image.