content/browser/renderer_host/clipboard_message_filter_unittest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/clipboard_message_filter_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/clipboard_message_filter_unittest.cc

diff --git a/content/browser/renderer_host/clipboard_message_filter_unittest.cc b/content/browser/renderer_host/clipboard_message_filter_unittest.cc

index 89909e5de94d1320597cc6ef462b37c07fbd93c3..4bc506edb269584e9013dfaa936923b999fd53f6 100644

--- a/content/browser/renderer_host/clipboard_message_filter_unittest.cc

+++ b/content/browser/renderer_host/clipboard_message_filter_unittest.cc

@@ -103,7 +103,6 @@ TEST_F(ClipboardMessageFilterTest, SimpleImage) {

ui::Clipboard::GetBitmapFormatType(), ui::CLIPBOARD_TYPE_COPY_PASTE));

SkBitmap actual = clipboard()->ReadImage(ui::CLIPBOARD_TYPE_COPY_PASTE);

- SkAutoLockPixels locked(actual);

EXPECT_EQ(sizeof(bitmap_data), actual.getSize());

EXPECT_EQ(0,

memcmp(bitmap_data, actual.getAddr32(0, 0), sizeof(bitmap_data)));