components/wallpaper/wallpaper_manager_base.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/wallpaper/wallpaper_manager_base.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/wallpaper/wallpaper_manager_base.cc

diff --git a/components/wallpaper/wallpaper_manager_base.cc b/components/wallpaper/wallpaper_manager_base.cc

index 188580d6e89d9facb63da745d0c4f3868210c0e3..5edfbc5c43c741aa230ba37f5dcbee6505af5863 100644

--- a/components/wallpaper/wallpaper_manager_base.cc

+++ b/components/wallpaper/wallpaper_manager_base.cc

@@ -431,7 +431,6 @@ bool WallpaperManagerBase::ResizeImage(

gfx::Size(resized_width, resized_height));

SkBitmap bitmap = *(resized_image.bitmap());

- SkAutoLockPixels lock_input(bitmap);

gfx::JPEGCodec::Encode(

reinterpret_cast<unsigned char*>(bitmap.getAddr32(0, 0)),

gfx::JPEGCodec::FORMAT_SkBitmap, bitmap.width(), bitmap.height(),